This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Replace getter with property based API #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imiric
force-pushed
the
feat/getters-begone
branch
from
d0945e3 to
99d94ff
Compare
Based on internal design discussion. Access by property is more idiomatic for JS. Also, s/stats/info/ based on feedback in grafana/k6#1863.
imiric
force-pushed
the
feat/getters-begone
branch
from
99d94ff to
c9af174
Compare
Closed
added 2 commits
August 6, 2021 17:02
This will now be based on grafana/k6#2108
imiric
force-pushed
the
feat/getters-begone
branch
from
4b540ad to
a417c77
Compare
mstoykov
reviewed
Aug 9, 2021
imiric
pushed a commit
that referenced
this pull request
Aug 12, 2021
imiric
force-pushed
the
feat/getters-begone
branch
from
c4508cb to
ea16909
Compare
mstoykov
reviewed
Aug 12, 2021
The current WIP branches depend on WIP branches of k6, so we can't build against k6 master. This should work for all cases...
imiric
force-pushed
the
feat/getters-begone
branch
from
2d2a90a to
01b22c7
Compare
added 2 commits
August 12, 2021 16:47
The v0.33.0 tag was moved in k6, which messed up the sum.golang.org proxy. We can remove this after the next k6 version is released.
mstoykov
approved these changes
Aug 13, 2021
Comment on lines
+183
to
+184
| "id": func() interface{} { return vuState.VUID }, | ||
| "idGlobal": func() interface{} { return vuState.VUIDGlobal }, |
There was a problem hiding this comment.
I am still of the opinion that this should be localId/instanceId and id, but this can be fixed later
There was a problem hiding this comment.
Yeah, let's leave that for a follow-up PR. There are likely others we want renamed too, and it's pretty straightforward.
mstoykov
approved these changes
Aug 13, 2021
mstoykov
approved these changes
Aug 26, 2021
codebien
approved these changes
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on internal design discussion. Access by property is more idiomatic for JS.
Also,
s/stats/info/based on feedback in grafana/k6#1863, though we could dropInfosince it's only used internally.This depends on grafana/k6#2108 and #1 so let's not merge it before those.
I'm not quite happy with it; it could probably be optimized, and there might be some
goja.Runtimemixing.And I think @mstoykov had some thoughts on property names that should be addressed.